Merged
Conversation
✅ Deploy Preview for confidential-tokens ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Contributor
WalkthroughThe Node.js version in the GitHub Actions setup action was updated from 20.x to 24.x, affecting the build environment configuration used across CI/CD workflows. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
📝 Coding Plan
Comment Tip You can disable poems in the walkthrough.Disable the |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
.github/actions/setup/action.yml (1)
9-14:⚠️ Potential issue | 🟠 MajorInclude Node major version in cache key to prevent cross-runtime
node_modulesreuse.Upgrading to
node-version: 24.xwhile keeping the cache key unchanged creates a risk of restoringnode_modulesbuilt under a different Node major version. Native modules have version-specific ABIs that break across Node majors, causing flaky CI failures on subsequent runs that restore stale cache entries.Proposed fix
- key: npm-v3-${{ hashFiles('**/package-lock.json') }} + key: npm-v3-node24-${{ runner.os }}-${{ hashFiles('**/package-lock.json') }}🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In @.github/actions/setup/action.yml around lines 9 - 14, The cache key for the actions/cache step ('uses: actions/cache@v4') currently only hashes package-lock.json and must include the Node major version to avoid restoring node_modules built for a different runtime; update the cache 'key' expression (the key field on the cache step) to incorporate the Node major (e.g., include the node-version or its major) so the cache is namespaced per Node runtime alongside the existing hash, ensuring separate caches for different Node majors.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Outside diff comments:
In @.github/actions/setup/action.yml:
- Around line 9-14: The cache key for the actions/cache step ('uses:
actions/cache@v4') currently only hashes package-lock.json and must include the
Node major version to avoid restoring node_modules built for a different
runtime; update the cache 'key' expression (the key field on the cache step) to
incorporate the Node major (e.g., include the node-version or its major) so the
cache is namespaced per Node runtime alongside the existing hash, ensuring
separate caches for different Node majors.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 5a63f5cd-6406-477c-9ab2-fcebbf26649a
📒 Files selected for processing (1)
.github/actions/setup/action.yml
arr00
added a commit
that referenced
this pull request
Mar 16, 2026
arr00
added a commit
that referenced
this pull request
Apr 1, 2026
* Start release candidate * Fix local docs generation (#320) * remove properties symlink * add properties.js * lint fix * Remove backwards compatibility from Batcher (#321) * Remove backwards compatibility from Batcher * Apply suggestion from @arr00 * Validate `fromToken` and `toToken` on construction (#322) * Validate `fromToken` on construction * use `ERC165Checker` * check toToken as well * directly validate to and from token * Add additional functions to `IERC7984ERC20Wrapper` (#323) * remove incorrect docs on `unwrap` function * add finalize unwrap and rate to wrapper interface * update batcher to use unwrap request ids instead of unwrap amounts * add `unwrapAmount` to wrapper interface for unwrap request introspection * additional docs * call getter for `unwrapAmount` in `finalizeUnwrap` * update events and errors appropriately * remove `ERC7984ERC20Wrapper` import * fix import order * Move events to interface from `ERC7984ERC20Wrapper` * add note on request id for `unwrap` * change mapping to be of `bytes32` identifiers * add changeset * Allow claiming on behalf of another account in batcher (#324) * Allow claiming on behalf of another account in batcher * revert on claim if users not part of the batch * add error on quit too * Add additional warnings to the batcher (#325) * Return a bytes32 unwrap id from the `_unwrap` function in `BatcherConfidential` (#326) * Return a bytes32 unwrap id from the `_unwrap` function in `BatcherConfidential` * modify warning * Document possible rounding down of user deposits (#327) * Document possible rounding down of user deposits * add contract level comment as well * up * Release v0.4.0 (rc) (#318) * Release v0.4.0 (rc) * update changelog * update changelog * Apply suggestion from @james-toussaint Co-authored-by: James Toussaint <33313130+james-toussaint@users.noreply.github.com> --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Arr00 <13561405+arr00@users.noreply.github.com> Co-authored-by: James Toussaint <33313130+james-toussaint@users.noreply.github.com> * Update node version to 24.x in CI (#328) * Exit release candidate * Release v0.4.0 (#335) * Release v0.4.0 * update changelog * remove changelog duplicate --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Arr00 <13561405+arr00@users.noreply.github.com> --------- Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Arr00 <13561405+arr00@users.noreply.github.com> Co-authored-by: James Toussaint <33313130+james-toussaint@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by CodeRabbit